ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h - Issue 15697019: Parametrize names of llc and ld nexes by reading them from the resource info JSON file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

Issue 15697019: Parametrize names of llc and ld nexes by reading them from the resource info JSON file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for Jan's review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/native_client/src/trusted/plugin/file_utils.h ('K') | « ppapi/native_client/src/trusted/plugin/plugin.gypi ('k') | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

index 963fd1e7dc2c44a6ceac3ee14a4a0514fbb530cb..d6ee015f96a96674a134225f3646b5f8138cfcfc 100644

--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

@@ -158,8 +158,10 @@ class PnaclCoordinator: public CallbackSource<FileStreamData> {

const PnaclOptions& pnacl_options,

const pp::CompletionCallback& translate_notify_callback);

+ // Callback for when the resource info JSON file has been read.

+ void ResourceInfoWasRead(int32_t pp_error);

// Callback for when llc and ld have been downloaded.

- // This is the first callback invoked in response to BitcodeToNative.

void ResourcesDidLoad(int32_t pp_error);

// Callbacks for temporary file related stages.