Parametrize names of llc and ld nexes by reading them from the resource info JSON file.

ppapi/native_client/src/trusted/plugin/file_utils.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Some common file utilities for plugin code.
+
+#ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_FILE_UTILS_H_
+#define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_FILE_UTILS_H_
+
+#include "native_client/src/include/nacl_string.h"
+#include "native_client/src/include/portability_io.h"
+#include "ppapi/c/pp_stdint.h"
+
+namespace plugin { namespace file_utils {

[jvoung (off chromium), 2013/05/23 20:33:19]

c++ readability: "When declaring nested namespaces, put each namespace on its
own line."

[eliben, 2013/05/23 20:54:25]

Done.

+
+enum StatusCode {
+  SUCCESS = 0,
+  ERROR_MEM_ALLOC = 1,
+  ERROR_OPEN = 2,
+  ERROR_FILE_TOO_LARGE = 3,
+  ERROR_STAT = 4,
+  ERROR_READ = 5
+};
+
+// Slurp the whole contents of the given file (fd - open file descriptor) into
+// out_buf. max_size_to_read is the maximal allowed size of the file.
+// If the file turns out to be larger, an error is returned. In any case,
+// fd is closed.
+StatusCode SlurpFile(int32_t fd,
+                     nacl::string& out_buf,
+                     size_t max_size_to_read = (1 << 20));
+
+} // namespace file_utils

[jvoung (off chromium), 2013/05/23 20:33:19]

2 spaces between } and // namespace

[eliben, 2013/05/23 20:54:25]

Done.

+} // namespace plugin
+
+#endif  // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_FILE_UTILS_H_
+