Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15697017: Move subresource archive loading out of ResourceLoader (Closed)

Created:
7 years, 7 months ago by Nate Chapin
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Move subresource archive loading out of ResourceLoader BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151344

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -116 lines) Patch
M Source/core/loader/DocumentLoader.h View 1 4 chunks +1 line, -13 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 3 4 4 chunks +12 lines, -90 lines 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 1 2 4 chunks +0 lines, -6 lines 0 comments Download
M Source/core/loader/archive/ArchiveResource.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/archive/ArchiveResource.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Nate Chapin
https://codereview.chromium.org/15697017/diff/2001/Source/core/loader/DocumentLoader.cpp File Source/core/loader/DocumentLoader.cpp (right): https://codereview.chromium.org/15697017/diff/2001/Source/core/loader/DocumentLoader.cpp#newcode854 Source/core/loader/DocumentLoader.cpp:854: cachedResource->finish(); This "loads" the ArchiveResource by directly populating the ...
7 years, 7 months ago (2013-05-22 23:28:46 UTC) #1
abarth-chromium
LGTM. Clever idea. https://codereview.chromium.org/15697017/diff/2001/Source/core/loader/DocumentLoader.cpp File Source/core/loader/DocumentLoader.cpp (right): https://codereview.chromium.org/15697017/diff/2001/Source/core/loader/DocumentLoader.cpp#newcode854 Source/core/loader/DocumentLoader.cpp:854: cachedResource->finish(); On 2013/05/22 23:28:46, Nate Chapin ...
7 years, 7 months ago (2013-05-23 17:10:07 UTC) #2
Nate Chapin
On 2013/05/23 17:10:07, abarth wrote: > LGTM. Clever idea. > > https://codereview.chromium.org/15697017/diff/2001/Source/core/loader/DocumentLoader.cpp > File Source/core/loader/DocumentLoader.cpp ...
7 years, 7 months ago (2013-05-23 17:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/2001
7 years, 7 months ago (2013-05-23 17:11:47 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7020
7 years, 7 months ago (2013-05-23 18:47:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/2001
7 years, 7 months ago (2013-05-24 16:04:26 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7372
7 years, 7 months ago (2013-05-24 17:26:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/2001
7 years, 7 months ago (2013-05-24 19:32:20 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10173
7 years, 7 months ago (2013-05-24 20:52:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/2001
7 years, 7 months ago (2013-05-24 22:17:34 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10196
7 years, 7 months ago (2013-05-24 23:14:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/2001
7 years, 6 months ago (2013-05-28 17:35:46 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7714
7 years, 6 months ago (2013-05-28 18:55:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/2001
7 years, 6 months ago (2013-05-28 22:34:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15697017/57002
7 years, 6 months ago (2013-05-28 23:32:26 UTC) #15
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 01:35:35 UTC) #16
Message was sent while issue was closed. 
Change committed as 151344

Powered by Google App Engine
This is Rietveld 408576698