Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15697012: Add printing of SkColorFilter-derived classes to debugger (Closed)

Created:
7 years, 7 months ago by robertphillips
Modified:
7 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

I wanted this so I could see the rest of the paint theverge site was using.

Patch Set 1 #

Patch Set 2 : Neaten up a bit #

Total comments: 2

Patch Set 3 : Remove unnecessary macros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -4 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 8 chunks +55 lines, -0 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years, 7 months ago (2013-05-22 18:28:11 UTC) #1
djsollen
https://codereview.chromium.org/15697012/diff/2001/src/core/SkPaint.cpp File src/core/SkPaint.cpp (right): https://codereview.chromium.org/15697012/diff/2001/src/core/SkPaint.cpp#newcode2332 src/core/SkPaint.cpp:2332: SkDEVCODE(colorFilter->toString(str);) why does this need SkDEVCODE if it is ...
7 years, 7 months ago (2013-05-22 19:13:50 UTC) #2
robertphillips
https://codereview.chromium.org/15697012/diff/2001/src/core/SkPaint.cpp File src/core/SkPaint.cpp (right): https://codereview.chromium.org/15697012/diff/2001/src/core/SkPaint.cpp#newcode2332 src/core/SkPaint.cpp:2332: SkDEVCODE(colorFilter->toString(str);) Can't go wrong with belt AND suspenders - ...
7 years, 7 months ago (2013-05-22 19:29:35 UTC) #3
djsollen
lgtm
7 years, 7 months ago (2013-05-22 20:04:54 UTC) #4
robertphillips
7 years, 7 months ago (2013-05-23 14:00:33 UTC) #5
Message was sent while issue was closed. 
committed as r9255

Powered by Google App Engine
This is Rietveld 408576698