Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: sdk/lib/_internal/compiler/implementation/world.dart

Issue 15697004: Add a proper HInvokeConstructorBody instead of mis-using HInvokeDynamicMethod. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/tracer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/world.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/world.dart (revision 23010)
+++ sdk/lib/_internal/compiler/implementation/world.dart (working copy)
@@ -206,6 +206,13 @@
}
SideEffects getSideEffectsOfElement(Element element) {
+ // The type inferrer (where the side effects are being computed),
+ // does not see generative constructor bodies because they are
+ // created by the backend. Also, it does not make any distinction
+ // between a constructor and its body for side effects. This
+ // implies that currently, the side effects of a constructor body
+ // contain the side effects of the initializers.
+ assert(!element.isGenerativeConstructorBody());
return sideEffects.putIfAbsent(element.declaration, () {
return new SideEffects();
});
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/tracer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698