Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: build/get_landmines.py

Issue 1569643002: Reland Pull the Activity context from WindowAndroid if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added landmine Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file emits the list of reasons why a particular build needs to be clobbered 7 This file emits the list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 """ 9 """
10 10
11 import sys 11 import sys
12 12
13 import landmine_utils 13 import landmine_utils
14 14
15 15
16 builder = landmine_utils.builder 16 builder = landmine_utils.builder
17 distributor = landmine_utils.distributor 17 distributor = landmine_utils.distributor
18 gyp_defines = landmine_utils.gyp_defines 18 gyp_defines = landmine_utils.gyp_defines
19 gyp_msvs_version = landmine_utils.gyp_msvs_version 19 gyp_msvs_version = landmine_utils.gyp_msvs_version
20 platform = landmine_utils.platform 20 platform = landmine_utils.platform
21 21
22 22
23 def print_landmines(): 23 def print_landmines():
24 """ 24 """
25 ALL LANDMINES ARE EMITTED FROM HERE. 25 ALL LANDMINES ARE EMITTED FROM HERE.
26 """ 26 """
27 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort 27 # DO NOT add landmines as part of a regular CL. Landmines are a last-effort
jbudorick 2016/01/08 23:54:35 If it's at all possible, let's try to avoid a land
28 # bandaid fix if a CL that got landed has a build dependency bug and all bots 28 # bandaid fix if a CL that got landed has a build dependency bug and all bots
29 # need to be cleaned up. If you're writing a new CL that causes build 29 # need to be cleaned up. If you're writing a new CL that causes build
30 # dependency problems, fix the dependency problems instead of adding a 30 # dependency problems, fix the dependency problems instead of adding a
31 # landmine. 31 # landmine.
32 32
33 if (distributor() == 'goma' and platform() == 'win32' and 33 if (distributor() == 'goma' and platform() == 'win32' and
34 builder() == 'ninja'): 34 builder() == 'ninja'):
35 print 'Need to clobber winja goma due to backend cwd cache fix.' 35 print 'Need to clobber winja goma due to backend cwd cache fix.'
36 if platform() == 'android': 36 if platform() == 'android':
37 print 'Clobber: to handle new way of suppressing findbugs failures.' 37 print 'Clobber: to handle new way of suppressing findbugs failures.'
38 print 'Clobber to fix gyp not rename package name (crbug.com/457038)' 38 print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
39 print 'Clobber to fix perf bots failing on compile for crbug.com/550410'
39 if platform() == 'win' and builder() == 'ninja': 40 if platform() == 'win' and builder() == 'ninja':
40 print 'Compile on cc_unittests fails due to symbols removed in r185063.' 41 print 'Compile on cc_unittests fails due to symbols removed in r185063.'
41 if platform() == 'linux' and builder() == 'ninja': 42 if platform() == 'linux' and builder() == 'ninja':
42 print 'Builders switching from make to ninja will clobber on this.' 43 print 'Builders switching from make to ninja will clobber on this.'
43 if platform() == 'mac': 44 if platform() == 'mac':
44 print 'Switching from bundle to unbundled dylib (issue 14743002).' 45 print 'Switching from bundle to unbundled dylib (issue 14743002).'
45 if platform() in ('win', 'mac'): 46 if platform() in ('win', 'mac'):
46 print ('Improper dependency for create_nmf.py broke in r240802, ' 47 print ('Improper dependency for create_nmf.py broke in r240802, '
47 'fixed in r240860.') 48 'fixed in r240860.')
48 if (platform() == 'win' and builder() == 'ninja' and 49 if (platform() == 'win' and builder() == 'ninja' and
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 print 'Clobber to get rid of evil libsqlite3.dylib (crbug.com/526208)' 82 print 'Clobber to get rid of evil libsqlite3.dylib (crbug.com/526208)'
82 83
83 84
84 def main(): 85 def main():
85 print_landmines() 86 print_landmines()
86 return 0 87 return 0
87 88
88 89
89 if __name__ == '__main__': 90 if __name__ == '__main__':
90 sys.exit(main()) 91 sys.exit(main())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698