Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Side by Side Diff: pkg/analyzer/lib/src/summary/resynthesize.dart

Issue 1569633003: Fix resynthesis of variables/fields with implicit types. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library summary_resynthesizer; 5 library summary_resynthesizer;
6 6
7 import 'package:analyzer/analyzer.dart'; 7 import 'package:analyzer/analyzer.dart';
8 import 'package:analyzer/src/generated/element.dart'; 8 import 'package:analyzer/src/generated/element.dart';
9 import 'package:analyzer/src/generated/element_handle.dart'; 9 import 'package:analyzer/src/generated/element_handle.dart';
10 import 'package:analyzer/src/generated/engine.dart'; 10 import 'package:analyzer/src/generated/engine.dart';
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 String name = element.name; 506 String name = element.name;
507 DartType type = element.type; 507 DartType type = element.type;
508 PropertyAccessorElementImpl getter = 508 PropertyAccessorElementImpl getter =
509 new PropertyAccessorElementImpl(name, -1); 509 new PropertyAccessorElementImpl(name, -1);
510 getter.getter = true; 510 getter.getter = true;
511 getter.static = element.isStatic; 511 getter.static = element.isStatic;
512 getter.synthetic = true; 512 getter.synthetic = true;
513 getter.returnType = type; 513 getter.returnType = type;
514 getter.type = new FunctionTypeImpl(getter); 514 getter.type = new FunctionTypeImpl(getter);
515 getter.variable = element; 515 getter.variable = element;
516 getter.hasImplicitReturnType = element.hasImplicitType;
516 holder.addAccessor(getter); 517 holder.addAccessor(getter);
517 element.getter = getter; 518 element.getter = getter;
518 if (!(element.isConst || element.isFinal)) { 519 if (!(element.isConst || element.isFinal)) {
519 PropertyAccessorElementImpl setter = 520 PropertyAccessorElementImpl setter =
520 new PropertyAccessorElementImpl(name, -1); 521 new PropertyAccessorElementImpl(name, -1);
521 setter.setter = true; 522 setter.setter = true;
522 setter.static = element.isStatic; 523 setter.static = element.isStatic;
523 setter.synthetic = true; 524 setter.synthetic = true;
524 setter.parameters = <ParameterElement>[ 525 setter.parameters = <ParameterElement>[
525 new ParameterElementImpl('_$name', -1) 526 new ParameterElementImpl('_$name', -1)
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
872 } 873 }
873 } 874 }
874 875
875 /** 876 /**
876 * Handle the parts that are common to top level variables and fields. 877 * Handle the parts that are common to top level variables and fields.
877 */ 878 */
878 void buildVariableCommonParts(PropertyInducingElementImpl element, 879 void buildVariableCommonParts(PropertyInducingElementImpl element,
879 UnlinkedVariable serializedVariable) { 880 UnlinkedVariable serializedVariable) {
880 element.type = buildType(serializedVariable.type); 881 element.type = buildType(serializedVariable.type);
881 element.const3 = serializedVariable.isConst; 882 element.const3 = serializedVariable.isConst;
883 element.hasImplicitType = serializedVariable.hasImplicitType;
882 } 884 }
883 885
884 /** 886 /**
885 * Finish creating a [TypeParameterElement] by deserializing its bound. 887 * Finish creating a [TypeParameterElement] by deserializing its bound.
886 */ 888 */
887 void finishTypeParameter(UnlinkedTypeParam serializedTypeParameter, 889 void finishTypeParameter(UnlinkedTypeParam serializedTypeParameter,
888 TypeParameterElementImpl typeParameterElement) { 890 TypeParameterElementImpl typeParameterElement) {
889 if (serializedTypeParameter.bound != null) { 891 if (serializedTypeParameter.bound != null) {
890 typeParameterElement.bound = buildType(serializedTypeParameter.bound); 892 typeParameterElement.bound = buildType(serializedTypeParameter.bound);
891 } 893 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
926 } 928 }
927 for (FunctionTypeAliasElement typeAlias in unit.functionTypeAliases) { 929 for (FunctionTypeAliasElement typeAlias in unit.functionTypeAliases) {
928 elementMap[typeAlias.name] = typeAlias; 930 elementMap[typeAlias.name] = typeAlias;
929 } 931 }
930 resummarizedElements[absoluteUri] = elementMap; 932 resummarizedElements[absoluteUri] = elementMap;
931 unitHolder = null; 933 unitHolder = null;
932 prelinkedUnit = null; 934 prelinkedUnit = null;
933 unlinkedUnit = null; 935 unlinkedUnit = null;
934 } 936 }
935 } 937 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698