Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1569613002: Add a token position to LoadLocal, StoreLocal, and LoadStaticField instructions (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a token position to LoadLocal, StoreLocal, and LoadStaticField instructions BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/6e4dcdf879dff0c2e81df68da075673331bf523c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 7 chunks +20 lines, -14 lines 0 comments Download
M runtime/vm/intermediate_language.h View 6 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 11 months ago (2016-01-06 21:10:41 UTC) #3
rmacnak
lgtm
4 years, 11 months ago (2016-01-06 21:27:47 UTC) #4
Cutch
4 years, 11 months ago (2016-01-06 21:29:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e4dcdf879dff0c2e81df68da075673331bf523c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698