Issue 1569593002: Improve null-check elimination and change backward traversal strategy.

Issue 1569593002: Improve null-check elimination and change backward traversal strategy. (Closed)

Created:
4 years, 11 months ago by asgerf

Modified:
4 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang), Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -54 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart	View	1	3 chunks	+24 lines, -25 lines	0 comments	Download
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		16 chunks	+80 lines, -29 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

I'm thinking we could add traverseInPreOrder as well (which does not need the intermediate list ...

4 years, 11 months ago (2016-01-06 20:25:55 UTC) #2

Kevin Millikin (Google)

LGTM. I'd be happy to get away from the trampolining visitor where we don't need ...

4 years, 11 months ago (2016-01-06 22:38:25 UTC) #3

asgerf

4 years, 11 months ago (2016-01-07 01:25:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
33b1d5205703d383d7d37e1c8b03b46a11624aca (presubmit successful).