Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1569553005: Use base/time/time_posix.cc on OS X and iOS. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base/time/time_posix.cc on OS X and iOS. OS X and iOS used different implementation than other platforms because time_t is a long, and thus only 32-bits. Since support for 32-bit OS X has been dropped, this decision can be reverted and OS X/iOS can share the POSIX implementation. Port ComputeCurrentTicks/ComputeThreadTicks from time_mac.cc to time_posix.cc as OS X/iOS does not have a working "clock_gettime". BUG=565574

Patch Set 1 #

Patch Set 2 : Fix compilation on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -257 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D base/time/time_mac.cc View 1 chunk +0 lines, -236 lines 0 comments Download
M base/time/time_posix.cc View 1 7 chunks +120 lines, -18 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698