Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issue 1569553004: ppapi: examples: audio_encode: reduce array buffer reallocations (Closed)

Created:
4 years, 11 months ago by llandwerlin-old
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: examples: audio_encode: prevent buffer reallocations Prevent buffer reallocations by using an array of buffers to save encoded audio data in and just create a buffer to contain all of them when the user wants to save the data to a file. BUG=570837 Committed: https://crrev.com/f0c88d2d5e63301459685e84f724da4163b32c4d Cr-Commit-Position: refs/heads/master@{#370940}

Patch Set 1 #

Patch Set 2 : Fix blob creation #

Patch Set 3 : Use a set of buffers to hold the encoded audio data #

Total comments: 1

Patch Set 4 : comment nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -66 lines) Patch
M ppapi/examples/audio_encode/audio_encode.html View 1 2 3 12 chunks +106 lines, -66 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
llandwerlin-old
Hi Bill, PTAL, This is a fix to avoid skipping audio frames due to too ...
4 years, 11 months ago (2016-01-20 15:53:42 UTC) #3
bbudge
lgtm https://codereview.chromium.org/1569553004/diff/40001/ppapi/examples/audio_encode/audio_encode.html File ppapi/examples/audio_encode/audio_encode.html (right): https://codereview.chromium.org/1569553004/diff/40001/ppapi/examples/audio_encode/audio_encode.html#newcode86 ppapi/examples/audio_encode/audio_encode.html:86: // Writes way data. s/way/wav ?
4 years, 11 months ago (2016-01-20 19:13:09 UTC) #4
llandwerlin-old
On 2016/01/20 19:13:09, bbudge wrote: > lgtm > > https://codereview.chromium.org/1569553004/diff/40001/ppapi/examples/audio_encode/audio_encode.html > File ppapi/examples/audio_encode/audio_encode.html (right): > ...
4 years, 11 months ago (2016-01-22 10:31:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569553004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569553004/60001
4 years, 11 months ago (2016-01-22 10:32:28 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-22 10:51:44 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 10:53:22 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f0c88d2d5e63301459685e84f724da4163b32c4d
Cr-Commit-Position: refs/heads/master@{#370940}

Powered by Google App Engine
This is Rietveld 408576698