runtime/vm/code_descriptors.h - Issue 1569523002: Fix VM bug with try-catch inside of try-finally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_descriptors.h

Issue 1569523002: Fix VM bug with try-catch inside of try-finally. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: added comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/code_descriptors.h

diff --git a/runtime/vm/code_descriptors.h b/runtime/vm/code_descriptors.h

index ebe15cf913797ff453338972b5d99ad75db95556..e24e186c788678cb5a63c292c0d4933966ee7ed1 100644

--- a/runtime/vm/code_descriptors.h

+++ b/runtime/vm/code_descriptors.h

@@ -102,6 +102,7 @@ class ExceptionHandlerList : public ZoneAllocated {

AddPlaceHolder();

}

list_[try_index].outer_try_index = outer_try_index;

+ ASSERT(list_[try_index].pc_offset == ExceptionHandlers::kInvalidPcOffset);

list_[try_index].pc_offset = pc_offset;

ASSERT(handler_types.IsZoneHandle());

list_[try_index].handler_types = &handler_types;

« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »