Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1569523002: Fix VM bug with try-catch inside of try-finally. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: added comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 (FlowGraphCompiler::IsUnboxedField(field) || 266 (FlowGraphCompiler::IsUnboxedField(field) ||
267 (!field.is_final() && (field.guarded_cid() == kIllegalCid))); 267 (!field.is_final() && (field.guarded_cid() == kIllegalCid)));
268 } 268 }
269 269
270 270
271 void FlowGraphCompiler::InitCompiler() { 271 void FlowGraphCompiler::InitCompiler() {
272 TimelineDurationScope tds(thread(), 272 TimelineDurationScope tds(thread(),
273 isolate()->GetCompilerStream(), 273 isolate()->GetCompilerStream(),
274 "InitCompiler"); 274 "InitCompiler");
275 pc_descriptors_list_ = new(zone()) DescriptorList(64); 275 pc_descriptors_list_ = new(zone()) DescriptorList(64);
276 exception_handlers_list_ = new(zone())ExceptionHandlerList(); 276 exception_handlers_list_ = new(zone()) ExceptionHandlerList();
277 block_info_.Clear(); 277 block_info_.Clear();
278 // Conservative detection of leaf routines used to remove the stack check 278 // Conservative detection of leaf routines used to remove the stack check
279 // on function entry. 279 // on function entry.
280 bool is_leaf = !parsed_function().function().IsClosureFunction() 280 bool is_leaf = !parsed_function().function().IsClosureFunction()
281 && is_optimizing() 281 && is_optimizing()
282 && !flow_graph().IsCompiledForOsr(); 282 && !flow_graph().IsCompiledForOsr();
283 // Initialize block info and search optimized (non-OSR) code for calls 283 // Initialize block info and search optimized (non-OSR) code for calls
284 // indicating a non-leaf routine and calls without IC data indicating 284 // indicating a non-leaf routine and calls without IC data indicating
285 // possible reoptimization. 285 // possible reoptimization.
286 for (int i = 0; i < block_order_.length(); ++i) { 286 for (int i = 0; i < block_order_.length(); ++i) {
(...skipping 1590 matching lines...) Expand 10 before | Expand all | Expand 10 after
1877 1877
1878 1878
1879 void FlowGraphCompiler::FrameStateClear() { 1879 void FlowGraphCompiler::FrameStateClear() {
1880 ASSERT(!is_optimizing()); 1880 ASSERT(!is_optimizing());
1881 frame_state_.TruncateTo(0); 1881 frame_state_.TruncateTo(0);
1882 } 1882 }
1883 #endif 1883 #endif
1884 1884
1885 1885
1886 } // namespace dart 1886 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698