Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1569503002: [Printing] Remove unnecessary styleResolverChanged(). (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Printing] Remove unnecessary styleResolverChanged(). styleResolverChanged is already called for media query changes in the following call chain: FrameView::adjustMediaTypeForPrinting() -> FrameView::setMediaType() -> Document::mediaQueryAffectingValueChanged() -> Document::styleResolverChanged() Calling it afterwards should not be necessary. R=mstensho@opera.com TEST=printing/print-media-recalc.html Committed: https://crrev.com/db8c7f0e2cc599c2f6048dc616ef1ca7aad73a83 Cr-Commit-Position: refs/heads/master@{#367895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 11 months ago (2016-01-06 14:38:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569503002/1
4 years, 11 months ago (2016-01-06 14:39:00 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 16:16:44 UTC) #5
mstensho (USE GERRIT)
lgtm
4 years, 11 months ago (2016-01-06 19:06:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569503002/1
4 years, 11 months ago (2016-01-06 20:27:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 20:37:17 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 20:38:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8c7f0e2cc599c2f6048dc616ef1ca7aad73a83
Cr-Commit-Position: refs/heads/master@{#367895}

Powered by Google App Engine
This is Rietveld 408576698