Issue 15695010: Add ProfileManager::AllowGetDefaultProfile()

Issue 15695010: Add ProfileManager::AllowGetDefaultProfile() (Closed)

Created:
7 years, 7 months ago by stevenjb

Modified:
7 years, 7 months ago

Reviewers:
stevenjb, Nikita (slow), sail, sky, Paweł Hajdan Jr., nkostylev (pls use chromium)

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, sail+watch_chromium.org, nona+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add ProfileManager::AllowGetDefaultProfile() This should prevent calls to GetDefaultProfile until CreateProfile is called. BUG=243364 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202165

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Patch Set 3 : Rebase #

Patch Set 4 : Fix browsertest #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils_browsertest.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

stevenjb

Fixing the unit tests was not as bad as I feared. This includes the changes ...

7 years, 7 months ago (2013-05-23 21:32:17 UTC) #1

Paweł Hajdan Jr.

LGTM with a nit https://codereview.chromium.org/15695010/diff/1/chrome/browser/profiles/profile_manager.h File chrome/browser/profiles/profile_manager.h (right): https://codereview.chromium.org/15695010/diff/1/chrome/browser/profiles/profile_manager.h#newcode61 chrome/browser/profiles/profile_manager.h:61: static void AllowGetDefaultProfile(); nit: Please ...

7 years, 7 months ago (2013-05-23 21:59:32 UTC) #3

stevenjb

https://codereview.chromium.org/15695010/diff/1/chrome/browser/profiles/profile_manager.h File chrome/browser/profiles/profile_manager.h (right): https://codereview.chromium.org/15695010/diff/1/chrome/browser/profiles/profile_manager.h#newcode61 chrome/browser/profiles/profile_manager.h:61: static void AllowGetDefaultProfile(); On 2013/05/23 21:59:32, Paweł Hajdan Jr. ...

7 years, 7 months ago (2013-05-23 23:15:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/15695010/24001

7 years, 7 months ago (2013-05-24 16:20:52 UTC) #6

Message was sent while issue was closed.

Change committed as 202165

Expand Messages | Collapse Messages