Merge to XFA: Return const-ref object in a few CPWL_Wnd getters.

fpdfsdk/include/pdfwindow/PWL_Wnd.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef FPDFSDK_INCLUDE_PDFWINDOW_PWL_WND_H_
 #define FPDFSDK_INCLUDE_PDFWINDOW_PWL_WND_H_
 
 #include "core/include/fpdfdoc/fpdf_doc.h"
@@ skipping 276 matching lines @@
   ~CPWL_Wnd() override;
 
   void Create(const PWL_CREATEPARAM& cp);
   virtual CFX_ByteString GetClassName() const;
   void InvalidateFocusHandler(IPWL_FocusHandler* handler);
   void InvalidateProvider(IPWL_Provider* provider);
   void Destroy();
   void Move(const CPDF_Rect& rcNew, FX_BOOL bReset, FX_BOOL bRefresh);
   virtual void InvalidateRect(CPDF_Rect* pRect = NULL);
 
-  void GetAppearanceStream(CFX_ByteString& sAppStream);
   void DrawAppearance(CFX_RenderDevice* pDevice, CFX_Matrix* pUser2Device);
 
   virtual FX_BOOL OnKeyDown(FX_WORD nChar, FX_DWORD nFlag);
   virtual FX_BOOL OnKeyUp(FX_WORD nChar, FX_DWORD nFlag);
   virtual FX_BOOL OnChar(FX_WORD nChar, FX_DWORD nFlag);
   virtual FX_BOOL OnLButtonDblClk(const CPDF_Point& point, FX_DWORD nFlag);
   virtual FX_BOOL OnLButtonDown(const CPDF_Point& point, FX_DWORD nFlag);
   virtual FX_BOOL OnLButtonUp(const CPDF_Point& point, FX_DWORD nFlag);
   virtual FX_BOOL OnMButtonDblClk(const CPDF_Point& point, FX_DWORD nFlag);
   virtual FX_BOOL OnMButtonDown(const CPDF_Point& point, FX_DWORD nFlag);
@@ skipping 26 matching lines @@
   virtual FX_FLOAT GetFontSize() const;
   virtual int32_t GetInnerBorderWidth() const;
   virtual CPWL_Color GetBorderLeftTopColor(int32_t nBorderStyle) const;
   virtual CPWL_Color GetBorderRightBottomColor(int32_t nBorderStyle) const;
 
   virtual FX_BOOL IsModified() const { return FALSE; }
 
   virtual void SetFontSize(FX_FLOAT fFontSize);
 
   void SetBackgroundColor(const CPWL_Color& color);
-  void SetBorderColor(const CPWL_Color& color);
-  void SetBorderWidth(int32_t nBorderWidth);
   void SetClipRect(const CPDF_Rect& rect);
   void SetBorderStyle(int32_t eBorderStyle);
-  void SetBorderDash(const CPWL_Dash& sDash);
 
-  CPDF_Rect GetOriginWindowRect() const;
   virtual CPDF_Rect GetWindowRect() const;
   virtual CPDF_Rect GetClientRect() const;
   CPDF_Point GetCenterPoint() const;
-  CPDF_Rect GetClientCenterSquare() const;
-  CPDF_Rect GetWindowCenterSquare() const;
   int32_t GetBorderWidth() const;
   FX_BOOL IsVisible() const { return m_bVisible; }
   FX_BOOL HasFlag(FX_DWORD dwFlags) const;
   void AddFlag(FX_DWORD dwFlags);
   void RemoveFlag(FX_DWORD dwFlags);
-  CPDF_Rect GetClipRect() const;
+  const CPDF_Rect& GetClipRect() const;
   CPWL_Wnd* GetParentWindow() const;
   int32_t GetBorderStyle() const;
-  CPWL_Dash GetBorderDash() const;
+  const CPWL_Dash& GetBorderDash() const;
   void* GetAttachedData() const;
 
   FX_BOOL WndHitTest(const CPDF_Point& point) const;
   FX_BOOL ClientHitTest(const CPDF_Point& point) const;
   FX_BOOL IsCaptureMouse() const;
 
   const CPWL_Wnd* GetFocused() const;
   FX_BOOL IsFocused() const;
   FX_BOOL IsReadOnly() const;
   CPWL_ScrollBar* GetVScrollBar() const;
@@ skipping 45 matching lines @@
 
   virtual void OnSetFocus();
   virtual void OnKillFocus();
 
   virtual void OnEnabled();
   virtual void OnDisabled();
 
   void SetNotifyFlag(FX_BOOL bNotifying = TRUE) { m_bNotifying = bNotifying; }
 
   FX_BOOL IsValid() const;
-  PWL_CREATEPARAM GetCreationParam() const;
+  const PWL_CREATEPARAM& GetCreationParam() const;
   FX_BOOL IsNotifying() const { return m_bNotifying; }
 
   void InvalidateRectMove(const CPDF_Rect& rcOld, const CPDF_Rect& rcNew);
 
   void PWLtoWnd(const CPDF_Point& point, int32_t& x, int32_t& y) const;
   FX_RECT PWLtoWnd(const CPDF_Rect& rect) const;
   FX_HWND GetAttachedHWnd() const;
 
   FX_BOOL IsWndCaptureMouse(const CPWL_Wnd* pWnd) const;
   FX_BOOL IsWndCaptureKeyboard(const CPWL_Wnd* pWnd) const;
@@ skipping 28 matching lines @@
   CPDF_Rect m_rcWindow;
   CPDF_Rect m_rcClip;
 
   FX_BOOL m_bCreated;
   FX_BOOL m_bVisible;
   FX_BOOL m_bNotifying;
   FX_BOOL m_bEnabled;
 };
 
 #endif  // FPDFSDK_INCLUDE_PDFWINDOW_PWL_WND_H_