Reject lack of "use asm" marker in asm typer.

Reject lack of "use asm" marker in asm typer.

Until now we've been allowing unmarked asm code
through the typer. Start rejecting it.

Adding a cctest that asm modules missing an export return
fail validation.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/0840e20764d5b522fb8fa35ee7e119f2a365adbc
Cr-Commit-Position: refs/heads/master@{#33199}

[aseemgarg, 2016-01-08 22:30:56]

LGTM, please clarify the comment on ensuring return in the module.

https://codereview.chromium.org/1569423002/diff/1/test/cctest/test-asm-valida...
File test/cctest/test-asm-validator.cc (right):

https://codereview.chromium.org/1569423002/diff/1/test/cctest/test-asm-valida...
test/cctest/test-asm-validator.cc:343: TEST(MissingReturnExports) {
Is this correct? Although useless, it is not clear from the spec that there has
to be a return (see the validate module section in asmjs spec). Basically for
empty module it is not clear do we write an empty return statement or no return
statement.

[bradn, 2016-01-09 01:05:52]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-01-09 01:05:53]

https://codereview.chromium.org/1569423002/diff/1/test/cctest/test-asm-valida...
File test/cctest/test-asm-validator.cc (right):

https://codereview.chromium.org/1569423002/diff/1/test/cctest/test-asm-valida...
test/cctest/test-asm-validator.cc:343: TEST(MissingReturnExports) {
On 2016/01/08 22:30:56, aseemgarg wrote:
> Is this correct? Although useless, it is not clear from the spec that there
has
> to be a return (see the validate module section in asmjs spec). Basically for
> empty module it is not clear do we write an empty return statement or no
return
> statement.

Actually it does seem to require a ValidateExports of the return (which I assume
requires one to exist).
I was adding this due to:
https://codereview.chromium.org/1564313003/
And the fuzzer bug that prompted it.

But now that I look at the spec, I notice that it allows for export of a single
function. I'm not sure I've ever seen a module like that before, but I will need
to look into handling that case.
I'll defer that to a future CL, as this test is still valid.

[bradn, 2016-01-09 01:05:56]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-01-09 01:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1569423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1569423002/1

[commit-bot: I haz the power, 2016-01-09 01:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-09 01:08:30]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9586)

[titzer, 2016-01-11 10:39:07]

On 2016/01/09 01:08:30, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9586)

lgtm

[titzer, 2016-01-11 10:39:11]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-01-11 10:39:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1569423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1569423002/1

[commit-bot: I haz the power, 2016-01-11 12:26:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-11 12:27:20]

Description was changed from

==========
Reject lack of "use asm" marker in asm typer.

Until now we've been allowing unmarked asm code
through the typer. Start rejecting it.

Adding a cctest that asm modules missing an export return
fail validation.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Reject lack of "use asm" marker in asm typer.

Until now we've been allowing unmarked asm code
through the typer. Start rejecting it.

Adding a cctest that asm modules missing an export return
fail validation.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/0840e20764d5b522fb8fa35ee7e119f2a365adbc
Cr-Commit-Position: refs/heads/master@{#33199}
==========

[commit-bot: I haz the power, 2016-01-11 12:27:21]

Patchset 1 (id:??) landed as
https://crrev.com/0840e20764d5b522fb8fa35ee7e119f2a365adbc
Cr-Commit-Position: refs/heads/master@{#33199}