Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 1569373002: Clean up order of arguments to d,s[,aa]. (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
lsalzman1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up order of arguments to d,s[,aa]. This gets rid of those unsightly lambdas, and makes the file more consistent both with itself and with Sk4px. BUG=skia:4765 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1569373002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/d9c0037211e1ae56c7b9628e69659e7f3df9081d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M src/opts/SkXfermode_opts.h View 5 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569373002/1
4 years, 11 months ago (2016-01-08 19:56:46 UTC) #3
mtklein_C
4 years, 11 months ago (2016-01-08 20:03:35 UTC) #5
lsalzman1
lgtm
4 years, 11 months ago (2016-01-08 20:09:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569373002/1
4 years, 11 months ago (2016-01-08 20:12:16 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 20:12:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d9c0037211e1ae56c7b9628e69659e7f3df9081d

Powered by Google App Engine
This is Rietveld 408576698