Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1569353002: MIPS: Fix `[date] Migrate Date field accessors to native builtins.' (Closed)

Created:
4 years, 11 months ago by balazs.kilvady
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix `[date] Migrate Date field accessors to native builtins.' Port fc5c7e0486038f8a615041963a13c9b7bb602469 Original commit message: There's no reason to have JavaScript wrappers for those accessors, since the meat is already in hand-written native code (via %_DateField). First step now to put them into native builtins. Next step will be to completely remove %_DateField. BUG= TEST=test262/built-ins/Date/prototype/toISOString/15.9.5.43-0-10, test262/built-ins/Date/prototype/toISOString/15.9.5.43-0-11, test262/built-ins/Date/S15.9.3.1_A5_T1 Committed: https://crrev.com/9de63d38d1e0221aaba7d4d9d4bfb5aa447af805 Cr-Commit-Position: refs/heads/master@{#33191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
balazs.kilvady
PTAL. The fix is just moving the return out from the 'FrameScope' scope.
4 years, 11 months ago (2016-01-08 19:24:23 UTC) #2
paul.l...
LGTM.
4 years, 11 months ago (2016-01-08 19:26:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569353002/1
4 years, 11 months ago (2016-01-08 19:27:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569353002/1
4 years, 11 months ago (2016-01-08 19:35:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 19:46:56 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 19:47:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9de63d38d1e0221aaba7d4d9d4bfb5aa447af805
Cr-Commit-Position: refs/heads/master@{#33191}

Powered by Google App Engine
This is Rietveld 408576698