Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1569343002: Fix infinite loop caused by parsing same indirect objects (Closed)

Created:
4 years, 11 months ago by Wei Li
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix infinite loop caused by parsing same indirect objects BUG=pdfium:343 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/149f1db8bba85bdf2b40d330c38f2478695ca0d5

Patch Set 1 #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : address comments #

Patch Set 4 : add const #

Patch Set 5 : name change #

Total comments: 1

Patch Set 6 : more name change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 4 5 2 chunks +19 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
A testing/resources/bug_343.pdf View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Wei Li
PTAL, thanks.
4 years, 11 months ago (2016-01-08 18:54:11 UTC) #1
Lei Zhang
https://codereview.chromium.org/1569343002/diff/20001/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1569343002/diff/20001/core/include/fpdfapi/fpdf_parser.h#newcode369 core/include/fpdfapi/fpdf_parser.h:369: class ScopedSetInsertion { Move this to fpdf_parser_parser.cpp's anonymous namespace ...
4 years, 11 months ago (2016-01-08 20:27:07 UTC) #2
Wei Li
https://codereview.chromium.org/1569343002/diff/20001/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1569343002/diff/20001/core/include/fpdfapi/fpdf_parser.h#newcode369 core/include/fpdfapi/fpdf_parser.h:369: class ScopedSetInsertion { On 2016/01/08 20:27:07, Lei Zhang wrote: ...
4 years, 11 months ago (2016-01-08 22:01:50 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1569343002/diff/80001/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1569343002/diff/80001/core/include/fpdfapi/fpdf_parser.h#newcode541 core/include/fpdfapi/fpdf_parser.h:541: std::set<FX_DWORD> m_ParsingObjnums; Nums
4 years, 11 months ago (2016-01-08 22:09:19 UTC) #4
Wei Li
4 years, 11 months ago (2016-01-08 22:26:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
149f1db8bba85bdf2b40d330c38f2478695ca0d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698