Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1569333002: Complete removal of MouseEvent prefixed webkitMovementX/Y. (Closed)

Created:
4 years, 11 months ago by scheib
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete removal of MouseEvent prefixed webkitMovementX/Y. Specification is for .movementX/Y and the prefixed versions have been deprecated for half a year now. Usage has dropped notably. Remaining usage seems to be due to code that copies all properties: e.g. https://github.com/taye/interact.js/blob/0b94aace680199b6261989363dfc102532c49a5d/interact.js#L547 function extend (dest, source) { for (var prop in source) { dest[prop] = source[prop]; } return dest; } e.g. https://github.com/highcharts/highcharts/issues/4568 BUG=398457 Committed: https://crrev.com/c3fe452564b833f119af60957e966ab56318be2e Cr-Commit-Position: refs/heads/master@{#369282}

Patch Set 1 : #

Messages

Total messages: 23 (11 generated)
scheib
4 years, 11 months ago (2016-01-09 22:37:04 UTC) #5
Rick Byers
LGTM, yay! Please reply on the old intent-to-remove thread just to let interested people know ...
4 years, 11 months ago (2016-01-11 15:40:17 UTC) #6
scheib
OWNERS R please: achuith: ui/login/account_picker/user_pod_row.js timvolodine: android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt
4 years, 11 months ago (2016-01-11 17:46:38 UTC) #8
achuithb
rubberstamp lgtm for user_pod_row
4 years, 11 months ago (2016-01-11 23:23:22 UTC) #9
scheib
boliu, OWNERS review please for: android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt
4 years, 11 months ago (2016-01-13 20:57:17 UTC) #11
boliu
On 2016/01/13 20:57:17, scheib wrote: > boliu, OWNERS review please for: > android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt lgtm
4 years, 11 months ago (2016-01-13 21:20:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569333002/40001
4 years, 11 months ago (2016-01-13 21:34:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-13 23:39:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569333002/40001
4 years, 11 months ago (2016-01-13 23:47:11 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 11 months ago (2016-01-14 01:53:35 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3fe452564b833f119af60957e966ab56318be2e Cr-Commit-Position: refs/heads/master@{#369282}
4 years, 11 months ago (2016-01-14 01:55:16 UTC) #22
timvolodine
4 years, 11 months ago (2016-01-14 13:19:36 UTC) #23
Message was sent while issue was closed.
On 2016/01/11 17:46:38, scheib wrote:
> OWNERS R please:
> 
> achuith: ui/login/account_picker/user_pod_row.js
> 
> timvolodine:
>
android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt

(late) lgtm ;)

Powered by Google App Engine
This is Rietveld 408576698