Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp

Issue 1569293003: Revert of ObjectPainter::paintAsStackingContext() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp b/third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp
index 4acc9168785ac8d8d5b88dc2abed8eb2c9a1cded..212349d7a658c235204ecbdbc8bd23b56ccfc6dc 100644
--- a/third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp
@@ -6,7 +6,7 @@
#include "core/layout/LayoutScrollbar.h"
#include "core/layout/LayoutScrollbarPart.h"
-#include "core/paint/ObjectPainter.h"
+#include "core/paint/BlockPainter.h"
#include "core/paint/PaintInfo.h"
#include "platform/graphics/GraphicsContext.h"
@@ -28,8 +28,18 @@
const_cast<LayoutScrollbarPart&>(layoutScrollbarPart).setWidth(rect.width());
const_cast<LayoutScrollbarPart&>(layoutScrollbarPart).setHeight(rect.height());
- PaintInfo paintInfo(graphicsContext, pixelSnappedIntRect(rect), PaintPhaseForeground, GlobalPaintNormalPhase, PaintLayerNoFlag);
- ObjectPainter(layoutScrollbarPart).paintAsPseudoStackingContext(paintInfo, paintOffset);
+ // Now do the paint.
+ PaintInfo paintInfo(graphicsContext, pixelSnappedIntRect(rect), PaintPhaseBlockBackground, GlobalPaintNormalPhase, PaintLayerNoFlag);
+ BlockPainter blockPainter(layoutScrollbarPart);
+ blockPainter.paint(paintInfo, paintOffset);
+ paintInfo.phase = PaintPhaseChildBlockBackgrounds;
+ blockPainter.paint(paintInfo, paintOffset);
+ paintInfo.phase = PaintPhaseFloat;
+ blockPainter.paint(paintInfo, paintOffset);
+ paintInfo.phase = PaintPhaseForeground;
+ blockPainter.paint(paintInfo, paintOffset);
+ paintInfo.phase = PaintPhaseOutline;
+ blockPainter.paint(paintInfo, paintOffset);
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698