Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: third_party/WebKit/Source/core/paint/BlockPainter.h

Issue 1569293003: Revert of ObjectPainter::paintAsStackingContext() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BlockPainter.h
diff --git a/third_party/WebKit/Source/core/paint/BlockPainter.h b/third_party/WebKit/Source/core/paint/BlockPainter.h
index 76359c610a7a97f48aaac93b13cf484976915c14..066b96a02d3c71e38fc678d05059476324df303d 100644
--- a/third_party/WebKit/Source/core/paint/BlockPainter.h
+++ b/third_party/WebKit/Source/core/paint/BlockPainter.h
@@ -27,10 +27,13 @@
void paintObject(const PaintInfo&, const LayoutPoint&);
void paintChildren(const PaintInfo&, const LayoutPoint&);
void paintChild(const LayoutBox&, const PaintInfo&, const LayoutPoint&);
+ void paintChildAsInlineBlock(const LayoutBox&, const PaintInfo&, const LayoutPoint&);
void paintOverflowControlsIfNeeded(const PaintInfo&, const LayoutPoint&);
- // See ObjectPainter::paintAsPseudoStackingContext for explanation of "pseudo stacking context".
- void paintChildAsPseudoStackingContext(const LayoutBox&, const PaintInfo&, const LayoutPoint&);
+ // inline-block elements paint all phases atomically. This function ensures that. Certain other elements
+ // (grid items, flex items) require this behavior as well, and this function exists as a helper for them.
+ // It is expected that the caller will call this function independent of the value of paintInfo.phase.
+ static void paintAsInlineBlock(const LayoutObject&, const PaintInfo&, const LayoutPoint&);
static void paintChildrenOfFlexibleBox(const LayoutFlexibleBox&, const PaintInfo&, const LayoutPoint& paintOffset);
static void paintInlineBox(const InlineBox&, const PaintInfo&, const LayoutPoint& paintOffset);
« no previous file with comments | « third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp ('k') | third_party/WebKit/Source/core/paint/BlockPainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698