Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1569283002: NaCl cleanup: Remove SrpcParams and SrpcClient, which are unused now (Closed)

Created:
4 years, 11 months ago by Mark Seaborn
Modified:
4 years, 11 months ago
Reviewers:
bbudge
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove SrpcParams and SrpcClient, which are unused now * Remove the NaClSrpcModuleInit() call. Since we no longer use SRPC, we don't need to initialise it. * NaClSubprocess: Remove SrpcClient field and constructor argument, since the SrpcClient object is no longer used. BUG=302078 TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation) Committed: https://crrev.com/3dbaa6aed5697f9ec80ba8f19a997eb2162bded1 Cr-Commit-Position: refs/heads/master@{#368440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -592 lines) Patch
M components/nacl/renderer/plugin/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/nacl/renderer/plugin/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/renderer/plugin/module_ppapi.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/nacl/renderer/plugin/nacl_subprocess.h View 4 chunks +1 line, -27 lines 0 comments Download
M components/nacl/renderer/plugin/nacl_subprocess.cc View 3 chunks +2 lines, -106 lines 0 comments Download
M components/nacl/renderer/plugin/plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/plugin/plugin.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/renderer/plugin/plugin.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/renderer/plugin/pnacl_coordinator.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/renderer/plugin/pnacl_coordinator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/renderer/plugin/service_runtime.h View 3 chunks +0 lines, -5 lines 0 comments Download
M components/nacl/renderer/plugin/service_runtime.cc View 2 chunks +0 lines, -13 lines 0 comments Download
D components/nacl/renderer/plugin/srpc_client.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/nacl/renderer/plugin/srpc_client.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D components/nacl/renderer/plugin/srpc_params.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/nacl/renderer/plugin/srpc_params.cc View 1 chunk +0 lines, -122 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569283002/1
4 years, 11 months ago (2016-01-08 17:34:55 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 18:11:15 UTC) #4
Mark Seaborn
4 years, 11 months ago (2016-01-08 20:04:38 UTC) #7
bbudge
Nice. LGTM
4 years, 11 months ago (2016-01-08 20:57:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569283002/1
4 years, 11 months ago (2016-01-08 21:25:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 21:55:50 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 21:58:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dbaa6aed5697f9ec80ba8f19a997eb2162bded1
Cr-Commit-Position: refs/heads/master@{#368440}

Powered by Google App Engine
This is Rietveld 408576698