Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

Issue 1569273004: Move ResourceOwner on to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win_chromium_compile_dbg_ng is the worst Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
index fe4bb95013ebca1f860fa72fab859bfc40ebabb1..4bfe9a855d2069a63fc18e3a5feaac64e6a2edfc 100644
--- a/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
+++ b/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp
@@ -102,9 +102,9 @@ TEST(LinkLoaderTest, Preload)
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
dummyPageHolder->frame().settings()->setScriptEnabled(true);
MockLinkLoaderClient loaderClient(testCase.shouldLoad);
- LinkLoader loader(&loaderClient);
+ OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(&loaderClient);
KURL hrefURL = KURL(KURL(), testCase.href);
- loader.loadLink(LinkRelAttribute("preload"),
+ loader->loadLink(LinkRelAttribute("preload"),
CrossOriginAttributeNotSet,
String(),
testCase.as,
@@ -149,10 +149,10 @@ TEST(LinkLoaderTest, DNSPrefetch)
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
dummyPageHolder->document().settings()->setDNSPrefetchingEnabled(true);
MockLinkLoaderClient loaderClient(testCase.shouldLoad);
- LinkLoader loader(&loaderClient);
+ OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(&loaderClient);
KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.com")), testCase.href);
NetworkHintsMock networkHints;
- loader.loadLink(LinkRelAttribute("dns-prefetch"),
+ loader->loadLink(LinkRelAttribute("dns-prefetch"),
CrossOriginAttributeNotSet,
String(),
String(),
@@ -183,10 +183,10 @@ TEST(LinkLoaderTest, Preconnect)
for (const auto& testCase : cases) {
OwnPtr<DummyPageHolder> dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
MockLinkLoaderClient loaderClient(testCase.shouldLoad);
- LinkLoader loader(&loaderClient);
+ OwnPtrWillBeRawPtr<LinkLoader> loader = LinkLoader::create(&loaderClient);
KURL hrefURL = KURL(KURL(ParsedURLStringTag(), String("http://example.com")), testCase.href);
NetworkHintsMock networkHints;
- loader.loadLink(LinkRelAttribute("preconnect"),
+ loader->loadLink(LinkRelAttribute("preconnect"),
testCase.crossOrigin,
String(),
String(),
« no previous file with comments | « third_party/WebKit/Source/core/loader/LinkLoader.cpp ('k') | third_party/WebKit/Source/core/loader/TextTrackLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698