Move ResourceOwner on to the oilpan heap.

third_party/WebKit/Source/core/fetch/ResourceOwner.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef ResourceOwner_h
 #define ResourceOwner_h
 
 #include "core/fetch/ResourcePtr.h"
 
 namespace blink {
 
 
 template<class R, class C = typename R::ClientType>
-class ResourceOwner : public C {
+class ResourceOwner : public WillBeGarbageCollectedMixin, public C {
+    WILL_BE_USING_PRE_FINALIZER(ResourceOwner, clearResource);
 public:
     using ResourceType = R;
 
     virtual ~ResourceOwner();
     ResourceType* resource() const { return m_resource.get(); }

[yhirano, 2016/01/14 11:55:29]

+DEFINE_INLINE_VIRTUAL_TRACE() {}

[Nate Chapin, 2016/01/14 22:54:01]

Done.

 
 protected:
     ResourceOwner();
-    ResourceOwner(const ResourceOwner& other) { setResource(other.resource()); }
-    explicit ResourceOwner(const ResourcePtr<ResourceType>&);
 
     void setResource(const ResourcePtr<ResourceType>&);
-    void clearResource();
-
-    ResourceOwner& operator=(const ResourceOwner& other);
+    void clearResource() { setResource(nullptr); }
 
 private:
     ResourcePtr<ResourceType> m_resource;
 };
 
 template<class R, class C>
 inline ResourceOwner<R, C>::ResourceOwner()
 {
+#if ENABLE(OILPAN)
+    ThreadState::current()->registerPreFinalizer(this);
+#endif
 }
 
 template<class R, class C>
 inline ResourceOwner<R, C>::~ResourceOwner()
 {
+#if !ENABLE(OILPAN)
     clearResource();
+#endif

[haraken, 2016/01/14 04:26:43]

Nit: In this CL it is safe to call clearResource in ResoureOwner's destructor
because m_resource is still not a Member. It won't be safe once you replace the
ResourcePtr with Member in your next CL.

[yhirano, 2016/01/14 11:55:29]

Oh, it's my fault, sorry.

[Nate Chapin, 2016/01/14 22:54:01]

Yeah, I should have caught that, too. Removing.

 }
 
 template<class R, class C>
-inline ResourceOwner<R, C>::ResourceOwner(const ResourcePtr<R>& resource)
-    : m_resource(resource)
-{
-    if (m_resource)
-        m_resource->addClient(this);
-}
-
-template<class R, class C>
 inline void ResourceOwner<R, C>::setResource(const ResourcePtr<R>& newResource)
 {
     if (newResource == m_resource)
         return;
 
     // Some ResourceClient implementations reenter this so
     // we need to prevent double removal.
     if (ResourcePtr<ResourceType> oldResource = m_resource) {
         m_resource.clear();
         oldResource->removeClient(this);
     }
 
     if (newResource) {
         m_resource = newResource;
         m_resource->addClient(this);
     }
 }
 
-template<class R, class C>
-inline void ResourceOwner<R, C>::clearResource()
-{
-    setResource(0);
-}
-
-template<class R, class C>
-inline ResourceOwner<R, C>& ResourceOwner<R, C>::operator=(const ResourceOwner<R, C>& other)
-{
-    if (this == &other)
-        return *this;
-    setResource(other.resource());
-    return *this;
-}
-
 } // namespace blink
 
 #endif