Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: mojo/devtools/common/devtoolslib/apptest_dart.py

Issue 1569213004: Fix dart apptest flake on android. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/apptest_dart.py
diff --git a/mojo/devtools/common/devtoolslib/apptest_dart.py b/mojo/devtools/common/devtoolslib/apptest_dart.py
index fe6131f8ac085a6dacf6d38e60a52632d69cfb23..3c7a685b644b83e3ce7bf39f59d1780ddc375330 100644
--- a/mojo/devtools/common/devtoolslib/apptest_dart.py
+++ b/mojo/devtools/common/devtoolslib/apptest_dart.py
@@ -12,7 +12,15 @@ _logging = logging.getLogger()
from devtoolslib.apptest import run_apptest
-SUCCESS_PATTERN = re.compile('^.+ .+: All tests passed!', re.MULTILINE)
+# The apptest framework guarantees that tearDownAll() is the last thing to be
+# called before the shell is terminated. Note that the shell may be terminated
+# before the "All tests passed!" string.
+#
+# So we pass on messages like:
+# 00:01 +3: (tearDownAll)
+# And fail on messages like:
+# 00:01 +2 -1: (tearDownAll)
+SUCCESS_PATTERN = re.compile(r'^\S+ \S+: \(tearDownAll\)', re.MULTILINE)
def _dart_apptest_output_test(output):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698