Eliminate phase parameter in constructors

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/mirrors.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 1708 matching lines @@
 
     type = redirect_type.raw();
     type_arguments = redirect_type.arguments();
 
     redirected_constructor = lookup_constructor.RedirectionTarget();
     ASSERT(!redirected_constructor.IsNull());
     redirected_klass = type.type_class();
   }
 
   const intptr_t num_explicit_args = explicit_args.Length();
-  const intptr_t num_implicit_args =
-      redirected_constructor.IsGenerativeConstructor() ? 2 : 1;
+  const intptr_t num_implicit_args = 1;
   const Array& args =
       Array::Handle(Array::New(num_implicit_args + num_explicit_args));
 
   // Copy over the explicit arguments.
   Object& explicit_argument = Object::Handle();
   for (int i = 0; i < num_explicit_args; i++) {
     explicit_argument = explicit_args.At(i);
     args.SetAt(i + num_implicit_args, explicit_argument);
   }
 
@@ skipping 10 matching lines @@
                       redirected_constructor,
                       explicit_args,
                       arg_names,
                       InvocationMirror::kConstructor,
                       InvocationMirror::kMethod);
     UNREACHABLE();
   }
 
   Instance& new_object = Instance::Handle();
   if (redirected_constructor.IsGenerativeConstructor()) {
-    // Constructors get the uninitialized object and a constructor phase. Note
-    // we have delayed allocation until after the function type and argument
-    // matching checks.
+    // Constructors get the uninitialized object.
+    // Note we have delayed allocation until after the function
+    // type and argument matching checks.
     new_object = Instance::New(redirected_klass);
     if (!type_arguments.IsNull()) {
       // The type arguments will be null if the class has no type parameters, in
       // which case the following call would fail because there is no slot
       // reserved in the object for the type vector.
       new_object.SetTypeArguments(type_arguments);
     }
     args.SetAt(0, new_object);
-    args.SetAt(1, Smi::Handle(Smi::New(Function::kCtorPhaseAll)));
   } else {
     // Factories get type arguments.
     args.SetAt(0, type_arguments);
   }
 
   // Invoke the constructor and return the new object.
   const Object& result =
       Object::Handle(DartEntry::InvokeFunction(redirected_constructor,
                                                args,
                                                args_descriptor_array));
@@ skipping 328 matching lines @@
 }
 
 DEFINE_NATIVE_ENTRY(TypeMirror_subtypeTest, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));
   return Bool::Get(a.IsSubtypeOf(b, NULL)).raw();
 }
 
 
 }  // namespace dart