Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1569173003: PPC: [date] Migrate Date field accessors to native builtins. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [date] Migrate Date field accessors to native builtins. Port fc5c7e0486038f8a615041963a13c9b7bb602469 Original commit message: There's no reason to have JavaScript wrappers for those accessors, since the meat is already in hand-written native code (via %_DateField). First step now to put them into native builtins. Next step will be to completely remove %_DateField. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/c52767e178fa32f54557059b191fb2bc782b815b Cr-Commit-Position: refs/heads/master@{#33187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-08 15:08:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569173003/1
4 years, 11 months ago (2016-01-08 15:08:36 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 15:35:59 UTC) #5
JoranSiu
On 2016/01/08 15:35:59, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-08 16:49:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569173003/1
4 years, 11 months ago (2016-01-08 16:50:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 16:51:37 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 16:52:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c52767e178fa32f54557059b191fb2bc782b815b
Cr-Commit-Position: refs/heads/master@{#33187}

Powered by Google App Engine
This is Rietveld 408576698