Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: media/media.gyp

Issue 1569053002: Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« media/BUILD.gn ('K') | « media/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 # Override to dynamically link the cras (ChromeOS audio) library. 8 # Override to dynamically link the cras (ChromeOS audio) library.
9 'use_cras%': 0, 9 'use_cras%': 0,
10 # Option e.g. for Linux distributions to link pulseaudio directly 10 # Option e.g. for Linux distributions to link pulseaudio directly
(...skipping 1115 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 'formats/mp4/hevc.cc', 1126 'formats/mp4/hevc.cc',
1127 'formats/mp4/hevc.h', 1127 'formats/mp4/hevc.h',
1128 ], 1128 ],
1129 }], 1129 }],
1130 ['proprietary_codecs==1 and enable_hevc_demuxing==1 and media_use_ffmpeg ==1', { 1130 ['proprietary_codecs==1 and enable_hevc_demuxing==1 and media_use_ffmpeg ==1', {
1131 'sources': [ 1131 'sources': [
1132 'filters/ffmpeg_h265_to_annex_b_bitstream_converter.cc', 1132 'filters/ffmpeg_h265_to_annex_b_bitstream_converter.cc',
1133 'filters/ffmpeg_h265_to_annex_b_bitstream_converter.h', 1133 'filters/ffmpeg_h265_to_annex_b_bitstream_converter.h',
1134 ], 1134 ],
1135 }], 1135 }],
1136 ['proprietary_codecs==1 and media_use_ffmpeg==1 and ffmpeg_branding=="Ch romium"', {
1137 'fail%': "<!(echo proprietary codecs and ffmpeg_branding set to Chromi um are incompatible; exit 1)>",
jrummell 2016/01/11 22:05:47 Not sure if fail needs to be a variable. 'fail' al
1138 }],
1136 ['target_arch=="ia32" or target_arch=="x64"', { 1139 ['target_arch=="ia32" or target_arch=="x64"', {
1137 'dependencies': [ 1140 'dependencies': [
1138 'media_asm', 1141 'media_asm',
1139 ], 1142 ],
1140 'sources': [ 1143 'sources': [
1141 'base/simd/convert_rgb_to_yuv_sse2.cc', 1144 'base/simd/convert_rgb_to_yuv_sse2.cc',
1142 'base/simd/convert_rgb_to_yuv_ssse3.cc', 1145 'base/simd/convert_rgb_to_yuv_ssse3.cc',
1143 'base/simd/convert_yuv_to_rgb_x86.cc', 1146 'base/simd/convert_yuv_to_rgb_x86.cc',
1144 'base/simd/filter_yuv_sse2.cc', 1147 'base/simd/filter_yuv_sse2.cc',
1145 ], 1148 ],
(...skipping 1017 matching lines...) Expand 10 before | Expand all | Expand 10 after
2163 'dependencies': [ 2166 'dependencies': [
2164 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck', 2167 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
2165 ], 2168 ],
2166 }], 2169 }],
2167 ], 2170 ],
2168 }, 2171 },
2169 ], 2172 ],
2170 }], 2173 }],
2171 ], 2174 ],
2172 } 2175 }
OLDNEW
« media/BUILD.gn ('K') | « media/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698