Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium

media/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/features.gni")
 import("//build/config/linux/pkg_config.gni")
 import("//build/config/ui.gni")
 import("//media/media_options.gni")
 import("//testing/test.gni")
 
 buildflag_header("media_features") {
   header = "media_features.h"
 
   flags =
       [ "ENABLE_MSE_MPEG2TS_STREAM_PARSER=$enable_mse_mpeg2ts_stream_parser" ]
 }
 
+# XXX how to get same behaviour as 'ffmpeg_branding%': "Chromium",
+if (proprietary_codecs && media_use_ffmpeg && ffmpeg_branding == "Chromium") {
+  #XXX how to fail ?
+  #proprietary codecs and ffmpeg_branding set to Chromium are incompatible
+}

[jrummell, 2016/01/11 22:05:47]

Looks like assert() is the way to fail. Maybe remove ffmpeg_branding ==
"Chromium" from the if, and add:

assert(ffmpeg_branding != "Chromium", "proprietary codecs and ffmpeg_branding
set to Chromium are incompatible")

[Julien Isorce Samsung, 2016/08/17 23:54:58]

Done, thx.

+
 # Common configuration for targets in the media directory.
 # NOT for exporting.
 config("media_config") {
   defines = []
   if (!media_use_libvpx) {
     defines += [ "MEDIA_DISABLE_LIBVPX" ]
   }
   if (!media_use_ffmpeg) {
     defines += [ "MEDIA_DISABLE_FFMPEG" ]
   }
@@ skipping 895 matching lines @@
       "//media/base:test_support",
       "//media/test:pipeline_integration_tests",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/ffmpeg",
       "//ui/gfx:test_support",
       "//ui/gfx/geometry",
     ]
   }
 }