Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1569033002: Add Element.nameOffset and LibraryElement.nameLength to summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Element.nameOffset and LibraryElement.nameLength to summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/acc709b46b53950e53ad645c954deaa3d0426ac8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -53 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 56 chunks +266 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 15 chunks +34 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 10 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 3 chunks +7 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 13 chunks +47 lines, -12 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 11 chunks +78 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-07 22:20:08 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-07 22:26:31 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-07 22:47:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
acc709b46b53950e53ad645c954deaa3d0426ac8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698