Set up some hooks for premul/swizzzle opts.

Set up some hooks for premul/swizzzle opts.

  You can call these as SkOpts::premul_xxxa, SkOpts::swaprb_xxxa, etc.

  For now, I just backed the function pointers with some (untested) portable
  code, which may autovectorize.  We can override with optimized versions in
  Init_ssse3() (in SkOpts_ssse3.cpp), Init_neon() (SkOpts_neon.cpp), etc.

BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1569013002

Committed: https://skia.googlesource.com/skia/+/a1bfaad00486883669e20a94cf8f7a8f4e34266a

[mtklein_C, 2016-01-07 21:24:28]

Description was changed from

==========
Set up some hooks for premul/swizzzle opts.

  You can call these as SkOpts::premul_xxxa, SkOpts::swaprb_xxxa, etc.

  For now, I just backed the function pointers with some (untested) portable
  code, which may autovectorize.  We can override with optimized versions in
  Init_ssse3() (in SkOpts_ssse3.cpp), Init_neon() (SkOpts_neon.cpp), etc.

BUG=skia:4767
==========

to

==========
Set up some hooks for premul/swizzzle opts.

  You can call these as SkOpts::premul_xxxa, SkOpts::swaprb_xxxa, etc.

  For now, I just backed the function pointers with some (untested) portable
  code, which may autovectorize.  We can override with optimized versions in
  Init_ssse3() (in SkOpts_ssse3.cpp), Init_neon() (SkOpts_neon.cpp), etc.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-07 21:26:58]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-07 21:27:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1569013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1569013002/1

[mtklein_C, 2016-01-07 21:28:50]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[msarett, 2016-01-07 21:35:06]

lgtm

Great, I'll start trying to hook up to this!

https://codereview.chromium.org/1569013002/diff/1/src/core/SkOpts.cpp
File src/core/SkOpts.cpp (right):

https://codereview.chromium.org/1569013002/diff/1/src/core/SkOpts.cpp#newcode63
src/core/SkOpts.cpp:63: r = (r*a+127)/255;
Currently, we use this:

static inline U8CPU SkMulDiv255Round(U16CPU a, U16CPU b) {
    SkASSERT(a <= 32767);
    SkASSERT(b <= 32767);
    unsigned prod = a*b + 128;
    return (prod + (prod >> 8)) >> 8;
}

Are these identical or will Gold annoy us if I hook up to these?

[mtklein, 2016-01-07 21:37:50]

On 2016/01/07 21:35:06, msarett wrote:
> lgtm
> 
> Great, I'll start trying to hook up to this!
> 
> https://codereview.chromium.org/1569013002/diff/1/src/core/SkOpts.cpp
> File src/core/SkOpts.cpp (right):
> 
>
https://codereview.chromium.org/1569013002/diff/1/src/core/SkOpts.cpp#newcode63
> src/core/SkOpts.cpp:63: r = (r*a+127)/255;
> Currently, we use this:
> 
> static inline U8CPU SkMulDiv255Round(U16CPU a, U16CPU b) {
>     SkASSERT(a <= 32767);
>     SkASSERT(b <= 32767);
>     unsigned prod = a*b + 128;
>     return (prod + (prod >> 8)) >> 8;
> }
> 
> Are these identical or will Gold annoy us if I hook up to these?

They're identical math.

[commit-bot: I haz the power, 2016-01-07 21:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 21:43:26]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-01-07 21:47:52]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-01-07 21:47:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1569013002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1569013002/1

[commit-bot: I haz the power, 2016-01-07 21:48:24]

Description was changed from

==========
Set up some hooks for premul/swizzzle opts.

  You can call these as SkOpts::premul_xxxa, SkOpts::swaprb_xxxa, etc.

  For now, I just backed the function pointers with some (untested) portable
  code, which may autovectorize.  We can override with optimized versions in
  Init_ssse3() (in SkOpts_ssse3.cpp), Init_neon() (SkOpts_neon.cpp), etc.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Set up some hooks for premul/swizzzle opts.

  You can call these as SkOpts::premul_xxxa, SkOpts::swaprb_xxxa, etc.

  For now, I just backed the function pointers with some (untested) portable
  code, which may autovectorize.  We can override with optimized versions in
  Init_ssse3() (in SkOpts_ssse3.cpp), Init_neon() (SkOpts_neon.cpp), etc.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a1bfaad00486883669e20a94cf8f7a8f4e34266a
==========

[commit-bot: I haz the power, 2016-01-07 21:48:25]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a1bfaad00486883669e20a94cf8f7a8f4e34266a