Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 15690020: [binding] Check own property on named property accessor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index d5aeca1ae5bdf3dddd6e36bdc1d8887ff2046c4a..f073eafcf8f020cbfaf78ffb813006197a579b0c 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -3394,6 +3394,8 @@ sub GenerateImplementationNamedPropertyGetter
$code .= " return v8Undefined();\n";
$code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
$code .= " return v8Undefined();\n";
+ $code .= " if (info.Holder()->HasRealNamedProperty(name))\n";
+ $code .= " return v8Undefined();\n";
haraken 2013/05/30 10:23:09 I got a bit confused. I thought you were saying th
}
$code .= "\n";
$code .= " ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));\n";
@@ -3440,6 +3442,8 @@ sub GenerateImplementationNamedPropertySetter
$code .= " return v8Undefined();\n";
$code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
$code .= " return v8Undefined();\n";
+ $code .= " if (info.Holder()->HasRealNamedProperty(name))\n";
+ $code .= " return v8Undefined();\n";
}
$code .= " ${implClassName}* collection = toNative(info.Holder());\n";
$code .= " V8TRYCATCH_FOR_V8STRINGRESOURCE(V8StringResource<>, propertyName, name);\n";

Powered by Google App Engine
This is Rietveld 408576698