Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 15690019: Sort histogram definitions alphabetically. (Closed)

Created:
7 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), hajimehoshi
Visibility:
Public.

Description

Sort histogram definitions alphabetically. Translate.LocalesOnDisabledByPrefs is not sorted correctly. Presubmit runs pretty print script and aborts upload. TBR=isherman NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tyoshino (SeeGerritForStatus)
Looks like commit-bot checked in the recent two CLs without pretty print checking for each ...
7 years, 6 months ago (2013-05-30 09:45:36 UTC) #1
Takashi Toyoshima
Oops, it looks like that our two CLs are merged in CQ with unexpected way. ...
7 years, 6 months ago (2013-05-30 10:12:27 UTC) #2
tyoshino (SeeGerritForStatus)
Committed patchset #1 manually as r203117.
7 years, 6 months ago (2013-05-30 11:08:52 UTC) #3
tyoshino (SeeGerritForStatus)
I agree. Taking this as kind of build break, committing.
7 years, 6 months ago (2013-05-30 11:10:19 UTC) #4
Ilya Sherman
7 years, 6 months ago (2013-05-30 22:09:45 UTC) #5
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698