Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2498)

Unified Diff: chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc

Issue 1568983002: Close the save card bubble on tab switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove HideBubble from SaveCardBubbleController Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
index 43e99aee6538a211de858bfcbc997b64fd0dd302..2b39c0d170e98d0e4696a2fcbe1f1677e0f2714a 100644
--- a/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
+++ b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
@@ -200,6 +200,13 @@ void SaveCardBubbleControllerImpl::ShowBubbleForUpload(
ShowBubble();
}
+void SaveCardBubbleControllerImpl::HideBubble() {
+ if (save_card_bubble_view_) {
+ save_card_bubble_view_->Hide();
+ save_card_bubble_view_ = nullptr;
Evan Stade 2016/01/12 01:24:37 do we not get onbubbleclosed?
Justin Donnelly 2016/01/12 04:24:37 No. Calling Hide() here nulls out the view's refer
+ }
+}
+
void SaveCardBubbleControllerImpl::ReshowBubble() {
is_reshow_ = true;
AutofillMetrics::LogSaveCardPromptMetric(
« no previous file with comments | « chrome/browser/ui/autofill/save_card_bubble_controller_impl.h ('k') | chrome/browser/ui/views/autofill/save_card_icon_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698