Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: chrome/browser/ui/views/autofill/save_card_icon_view.cc

Issue 1568983002: Close the save card bubble on tab switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove HideBubble from SaveCardBubbleController Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/autofill/save_card_icon_view.h" 5 #include "chrome/browser/ui/views/autofill/save_card_icon_view.h"
6 6
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h" 8 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
11 #include "chrome/browser/ui/view_ids.h" 11 #include "chrome/browser/ui/view_ids.h"
12 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h" 12 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h"
13 #include "chrome/grit/generated_resources.h" 13 #include "chrome/grit/generated_resources.h"
14 #include "ui/base/l10n/l10n_util.h" 14 #include "ui/base/l10n/l10n_util.h"
15 #include "ui/gfx/vector_icons_public.h" 15 #include "ui/gfx/vector_icons_public.h"
16 16
17 namespace autofill { 17 namespace autofill {
18 18
19 SaveCardIconView::SaveCardIconView(CommandUpdater* command_updater, 19 SaveCardIconView::SaveCardIconView(CommandUpdater* command_updater,
20 Browser* browser) 20 Browser* browser)
21 : BubbleIconView(command_updater, IDC_SAVE_CREDIT_CARD_FOR_PAGE), 21 : BubbleIconView(command_updater, IDC_SAVE_CREDIT_CARD_FOR_PAGE),
22 browser_(browser) { 22 browser_(browser) {
23 set_id(VIEW_ID_SAVE_CREDIT_CARD_BUTTON); 23 set_id(VIEW_ID_SAVE_CREDIT_CARD_BUTTON);
24 SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_SAVE_CREDIT_CARD)); 24 SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_SAVE_CREDIT_CARD));
25 if (browser)
26 browser->tab_strip_model()->AddObserver(this);
25 } 27 }
26 28
27 SaveCardIconView::~SaveCardIconView() {} 29 SaveCardIconView::~SaveCardIconView() {}
28 30
29 void SaveCardIconView::OnExecuting( 31 void SaveCardIconView::OnExecuting(
30 BubbleIconView::ExecuteSource execute_source) {} 32 BubbleIconView::ExecuteSource execute_source) {}
31 33
32 views::BubbleDelegateView* SaveCardIconView::GetBubble() const { 34 views::BubbleDelegateView* SaveCardIconView::GetBubble() const {
33 if (!browser_) 35 SaveCardBubbleControllerImpl* controller = GetController();
34 return nullptr;
35 content::WebContents* web_contents =
36 browser_->tab_strip_model()->GetActiveWebContents();
37 if (!web_contents)
38 return nullptr;
39 autofill::SaveCardBubbleControllerImpl* controller =
40 autofill::SaveCardBubbleControllerImpl::FromWebContents(web_contents);
41 if (!controller) 36 if (!controller)
42 return nullptr; 37 return nullptr;
43 38
44 return static_cast<autofill::SaveCardBubbleViews*>( 39 return static_cast<autofill::SaveCardBubbleViews*>(
45 controller->save_card_bubble_view()); 40 controller->save_card_bubble_view());
46 } 41 }
47 42
48 gfx::VectorIconId SaveCardIconView::GetVectorIcon() const { 43 gfx::VectorIconId SaveCardIconView::GetVectorIcon() const {
49 return gfx::VectorIconId::CREDIT_CARD; 44 return gfx::VectorIconId::CREDIT_CARD;
50 } 45 }
51 46
47 void SaveCardIconView::TabDeactivated(content::WebContents* contents) {
48 SaveCardBubbleControllerImpl* controller = GetController();
49 if (controller)
50 controller->HideBubble();
51 }
52
53 SaveCardBubbleControllerImpl* SaveCardIconView::GetController() const {
54 if (!browser_)
55 return nullptr;
56 content::WebContents* web_contents =
57 browser_->tab_strip_model()->GetActiveWebContents();
58 if (!web_contents)
59 return nullptr;
60 return autofill::SaveCardBubbleControllerImpl::FromWebContents(web_contents);
61 }
62
52 } // namespace autofill 63 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698