Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/ui/autofill/save_card_bubble_controller_impl.h

Issue 1568983002: Close the save card bubble on tab switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove HideBubble from SaveCardBubbleController Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_ 5 #ifndef CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_
6 #define CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_ 6 #define CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/timer/elapsed_timer.h" 10 #include "base/timer/elapsed_timer.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 // 2. Two or more consecutive dollar signs in the template string will not 52 // 2. Two or more consecutive dollar signs in the template string will not
53 // expand correctly. 53 // expand correctly.
54 // 3. "${" anywhere in the template string is invalid. 54 // 3. "${" anywhere in the template string is invalid.
55 // 4. "\n" embedded anywhere in the template string, or an empty template 55 // 4. "\n" embedded anywhere in the template string, or an empty template
56 // string, can be used to separate paragraphs. It is not possible to create 56 // string, can be used to separate paragraphs. It is not possible to create
57 // a completely blank line by using two consecutive newlines (they will be 57 // a completely blank line by using two consecutive newlines (they will be
58 // treated as a single newline by views::StyledLabel). 58 // treated as a single newline by views::StyledLabel).
59 void ShowBubbleForUpload(const base::Closure& save_card_callback, 59 void ShowBubbleForUpload(const base::Closure& save_card_callback,
60 scoped_ptr<base::DictionaryValue> legal_message); 60 scoped_ptr<base::DictionaryValue> legal_message);
61 61
62 void HideBubble();
62 void ReshowBubble(); 63 void ReshowBubble();
63 64
64 // Returns true if Omnibox save credit card icon should be visible. 65 // Returns true if Omnibox save credit card icon should be visible.
65 bool IsIconVisible() const; 66 bool IsIconVisible() const;
66 67
67 // Returns nullptr if no bubble is currently shown. 68 // Returns nullptr if no bubble is currently shown.
68 SaveCardBubbleView* save_card_bubble_view() const; 69 SaveCardBubbleView* save_card_bubble_view() const;
69 70
70 // SaveCardBubbleController: 71 // SaveCardBubbleController:
71 base::string16 GetWindowTitle() const override; 72 base::string16 GetWindowTitle() const override;
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // Used to measure the amount of time on a page; if it's less than some 122 // Used to measure the amount of time on a page; if it's less than some
122 // reasonable limit, then don't close the bubble upon navigation. 123 // reasonable limit, then don't close the bubble upon navigation.
123 scoped_ptr<base::ElapsedTimer> timer_; 124 scoped_ptr<base::ElapsedTimer> timer_;
124 125
125 DISALLOW_COPY_AND_ASSIGN(SaveCardBubbleControllerImpl); 126 DISALLOW_COPY_AND_ASSIGN(SaveCardBubbleControllerImpl);
126 }; 127 };
127 128
128 } // namespace autofill 129 } // namespace autofill
129 130
130 #endif // CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_ 131 #endif // CHROME_BROWSER_UI_AUTOFILL_SAVE_CARD_BUBBLE_CONTROLLER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698