Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1568963003: Revert of Settings People Revamp: Implement Chrome Profile name/icon selection. (Closed)

Created:
4 years, 11 months ago by Łukasz Anforowicz
Modified:
4 years, 11 months ago
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Settings People Revamp: Implement Chrome Profile name/icon selection. (patchset #13 id:240001 of https://codereview.chromium.org/1536593004/ ) Reason for revert: This is the main suspect for causing a build failure below: https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/44384/steps/generate_gyp_files/logs/stdio Original issue's description: > Settings People Revamp: Implement Chrome Profile name/icon selection. > > 1) Decouple the profile icon and name updates from the > SyncStatus struct. They are now updated separately. > See SyncPrivateApi.getProfileInfo. > > 2) Updates PeopleHandler to send new profile icon and name > updates in response to these changing. > > 3) Copies a subset of options::ManageProfileHandler to > settings::ManageProfileHandler. The parts left behind are > functionality that will be subsumed by the new native User Manager. > > 4) Implements new functions necessary for manage_profile.html page in SyncPrivateApi. > > 5) Adds a manage_profile.html subpage that allows Chrome users to switch their name and icon. > > BUG=563721 > > Committed: https://crrev.com/9cb23370b8d9d2f0bdaed145e5682ac862c424e1 > Cr-Commit-Position: refs/heads/master@{#368181} TBR=dschuyler@chromium.org,dbeam@chromium.org,tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563721 Committed: https://crrev.com/e3ea96d84335e7bc9249b3355bd8b92346508edf Cr-Commit-Position: refs/heads/master@{#368188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -736 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/compiled_resources.gyp View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/resources/settings/people_page/manage_profile.css View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/settings/people_page/manage_profile.html View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/resources/settings/people_page/manage_profile.js View 1 chunk +0 lines, -96 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 3 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.js View 2 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_private_api.js View 2 chunks +2 lines, -52 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/compiled_resources.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_router.js View 3 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 4 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 5 chunks +7 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler_unittest.cc View 15 chunks +20 lines, -29 lines 0 comments Download
D chrome/browser/ui/webui/settings/settings_manage_profile_handler.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Łukasz Anforowicz
Created Revert of Settings People Revamp: Implement Chrome Profile name/icon selection.
4 years, 11 months ago (2016-01-07 23:18:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568963003/1
4 years, 11 months ago (2016-01-07 23:18:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 23:20:27 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 23:21:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3ea96d84335e7bc9249b3355bd8b92346508edf
Cr-Commit-Position: refs/heads/master@{#368188}

Powered by Google App Engine
This is Rietveld 408576698