Chromium Code Reviews
DescriptionRevert of Settings People Revamp: Implement Chrome Profile name/icon selection. (patchset #13 id:240001 of https://codereview.chromium.org/1536593004/ )
Reason for revert:
This is the main suspect for causing a build failure below:
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/44384/steps/generate_gyp_files/logs/stdio
Original issue's description:
> Settings People Revamp: Implement Chrome Profile name/icon selection.
>
> 1) Decouple the profile icon and name updates from the
> SyncStatus struct. They are now updated separately.
> See SyncPrivateApi.getProfileInfo.
>
> 2) Updates PeopleHandler to send new profile icon and name
> updates in response to these changing.
>
> 3) Copies a subset of options::ManageProfileHandler to
> settings::ManageProfileHandler. The parts left behind are
> functionality that will be subsumed by the new native User Manager.
>
> 4) Implements new functions necessary for manage_profile.html page in SyncPrivateApi.
>
> 5) Adds a manage_profile.html subpage that allows Chrome users to switch their name and icon.
>
> BUG=563721
>
> Committed: https://crrev.com/9cb23370b8d9d2f0bdaed145e5682ac862c424e1
> Cr-Commit-Position: refs/heads/master@{#368181}
TBR=dschuyler@chromium.org,dbeam@chromium.org,tommycli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=563721
Committed: https://crrev.com/e3ea96d84335e7bc9249b3355bd8b92346508edf
Cr-Commit-Position: refs/heads/master@{#368188}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|