Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1568933002: Add VDIVS and VDIVD instructions to the integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add test case. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -37 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 2 chunks +43 lines, -13 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
A + tests_lit/assembler/arm32/vdiv.ll View 1 2 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 11 months ago (2016-01-07 19:14:24 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1568933002/diff/20001/src/IceAssemblerARM32.cpp File src/IceAssemblerARM32.cpp (right): https://codereview.chromium.org/1568933002/diff/20001/src/IceAssemblerARM32.cpp#newcode2109 src/IceAssemblerARM32.cpp:2109: // cccc11100D11nnnndddd101sN1M0mmmm where cccc=Cond, s=0, ddddD=Rd, nnnnN=Rn, Why ...
4 years, 11 months ago (2016-01-07 20:50:31 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as 3dbe780686601ac6ed753b81c91ca1b6ec84bdeb (presubmit successful).
4 years, 11 months ago (2016-01-07 21:37:43 UTC) #6
Karl
4 years, 11 months ago (2016-01-07 21:37:59 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1568933002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1568933002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2109: // cccc11100D11nnnndddd101sN1M0mmmm  where
cccc=Cond, s=0, ddddD=Rd, nnnnN=Rn,
On 2016/01/07 20:50:31, stichnot wrote:
> Why the extra space character here?

Slow stutter I guess. Removed.

Powered by Google App Engine
This is Rietveld 408576698