Issue 156893004: Handle zero width joiner in HarfBuzzShaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156893004: Handle zero width joiner in HarfBuzzShaper (Closed)

Created:
6 years, 10 months ago by eae

Modified:
6 years, 10 months ago

Reviewers:
dglazkov, eseidel

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Handle zero width joiner in HarfBuzzShaper Change HarfBuzzShaper to handle zero width joiners. Before when a zwj was encountered it would start a new text run and use the font data for the zwj character. Now it instead uses the font data for the character it joins with and is a part of the same run. TEST=fast/text/international/zerowidthjoiner.html BUG=311372 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166685

Patch Set 1 #

Patch Set 2 : Exclude test on mac (as it does not yet use harfbuzz) #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
M	LayoutTests/NeverFixTests	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text/international/zerowidthjoiner.html	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text/international/zerowidthjoiner-expected.html	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/156893004/50001

6 years, 10 months ago (2014-02-07 05:50:10 UTC) #5

Message was sent while issue was closed.

Change committed as 166685

Expand Messages | Collapse Messages