Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1568883003: remove SkGPipe (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
mtklein, borenet, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3448 lines) Patch
M dm/DM.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMSrcSink.h View 2 chunks +0 lines, -7 lines 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M gyp/FileReaderApp.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/SampleApp.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M gyp/core.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/core.gypi View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/dm.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/pathops_skpclip.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/pipe/SkGPipe.h View 1 chunk +0 lines, -174 lines 0 comments Download
M samplecode/SampleApp.h View 1 chunk +0 lines, -6 lines 0 comments Download
M samplecode/SampleApp.cpp View 11 chunks +0 lines, -166 lines 0 comments Download
M samplecode/SampleCode.h View 1 chunk +0 lines, -1 line 0 comments Download
D src/pipe/SkGPipePriv.h View 1 chunk +0 lines, -313 lines 0 comments Download
D src/pipe/SkGPipeRead.cpp View 1 chunk +0 lines, -1009 lines 0 comments Download
D src/pipe/SkGPipeWrite.cpp View 1 chunk +0 lines, -1483 lines 0 comments Download
D src/pipe/utils/SamplePipeControllers.h View 1 chunk +0 lines, -87 lines 0 comments Download
D src/pipe/utils/SamplePipeControllers.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
D tests/PipeTest.cpp View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
reed1
4 years, 11 months ago (2016-01-07 20:44:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568883003/1
4 years, 11 months ago (2016-01-07 20:45:31 UTC) #5
mtklein
lgtm I am happy to follow up with the (tiny) tools/dm_flags.py cleanup.
4 years, 11 months ago (2016-01-07 20:47:32 UTC) #6
f(malita)
LGTM!
4 years, 11 months ago (2016-01-07 20:51:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568883003/1
4 years, 11 months ago (2016-01-07 20:52:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568883003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568883003/20001
4 years, 11 months ago (2016-01-08 14:13:45 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 14:30:23 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7c554222ddd03d3817ab197a0bd92badc6f1f7c9

Powered by Google App Engine
This is Rietveld 408576698