Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1568863002: Fix^3 cast in HasEnumerableElements (Closed)

Created:
4 years, 11 months ago by Jakob Kummerow
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix^3 cast in HasEnumerableElements Empty FixedDoubleArrays aren't FixedDoubleArrays. BUG=chromium:569534 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/a0d03d729a7257c52f9f95e1c36782c3448c1110 Cr-Commit-Position: refs/heads/master@{#33158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +5 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-569534.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
4 years, 11 months ago (2016-01-07 13:56:19 UTC) #1
Yang
On 2016/01/07 13:56:19, Jakob wrote: lgtm.
4 years, 11 months ago (2016-01-07 13:57:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568863002/1
4 years, 11 months ago (2016-01-07 14:00:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 14:47:15 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 14:47:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a0d03d729a7257c52f9f95e1c36782c3448c1110
Cr-Commit-Position: refs/heads/master@{#33158}

Powered by Google App Engine
This is Rietveld 408576698