Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1568813002: Let clients update icons for buttons on bottombar through service (Closed)

Created:
4 years, 11 months ago by Ian Wen
Modified:
4 years, 11 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@bottom_bar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let clients update icons for buttons on bottombar through service This CL enables updateVisuals() to find the button related to the given id, and update the icon/description of it. Bottom bar button updating is also included in this CL. BUG=573683 Committed: https://crrev.com/0779495a7e4924c3e4a33d43e1964f06cb6b8b00 Cr-Commit-Position: refs/heads/master@{#369227}

Patch Set 1 #

Patch Set 2 : Don't cache view in activity #

Total comments: 11

Patch Set 3 : #

Patch Set 4 : Respond to comments #

Total comments: 4

Patch Set 5 : tag->id #

Messages

Total messages: 12 (3 generated)
Ian Wen
4 years, 11 months ago (2016-01-08 00:21:02 UTC) #2
Yusuf
https://codereview.chromium.org/1568813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/1568813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode457 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:457: if (params == null) return; can params be null ...
4 years, 11 months ago (2016-01-08 06:34:23 UTC) #3
Ian Wen
https://codereview.chromium.org/1568813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/1568813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode457 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:457: if (params == null) return; On 2016/01/08 06:34:22, Yusuf ...
4 years, 11 months ago (2016-01-08 08:43:59 UTC) #4
Yusuf
https://codereview.chromium.org/1568813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/1568813002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode477 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:477: int buttonNum = bottomBar.getChildCount(); On 2016/01/08 08:43:58, Ian Wen ...
4 years, 11 months ago (2016-01-09 00:14:22 UTC) #5
Ian Wen
Replaced Tag with ID in view. PTAL https://codereview.chromium.org/1568813002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java (right): https://codereview.chromium.org/1568813002/diff/60001/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java#newcode475 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:475: Integer id ...
4 years, 11 months ago (2016-01-12 22:30:53 UTC) #6
Yusuf
lgtm
4 years, 11 months ago (2016-01-13 05:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568813002/80001
4 years, 11 months ago (2016-01-13 18:18:20 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-13 18:58:03 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 18:59:04 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0779495a7e4924c3e4a33d43e1964f06cb6b8b00
Cr-Commit-Position: refs/heads/master@{#369227}

Powered by Google App Engine
This is Rietveld 408576698