Issue 15688007: Fixes crash in AudioInputVolumeTest.InputVolumeTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15688007: Fixes crash in AudioInputVolumeTest.InputVolumeTest (Closed)

Created:
7 years, 6 months ago by henrika (OOO until Aug 14)

Modified:
7 years, 6 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes crash in AudioInputVolumeTest.InputVolumeTest. My CL https://codereview.chromium.org/15563004 broke this test. http://build.chromium.org/p/chromium.memory.fyi/ Failure notification for "memory test: media" on "Chromium Mac (valgrind)(1)". Please see if the failures are related to your commit and take appropriate actions (e.g. revert, update suppressions, notify sheriff, etc.). http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/20942 Revision: 202536, 202537, 202538, 202540, 202541, 202542 Blame list: eseidel@chromium.org,glider@chromium.org,henrika@chromium.org,kinuko@chromium.org,mtomasz@chromium.org,tzik@chromium.org BUG=see details above TEST=media_unittests --gtest_filter=AudioInputVolumeTest.InputVolumeTest* in Debug mode on device with audio hardware R=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202557

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	media/audio/agc_audio_stream.h	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

henrika (OOO until Aug 14)

7 years, 6 months ago (2013-05-28 14:19:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r202557 (presubmit successful).