Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: content/browser/media/webrtc_browsertest.cc

Issue 15688006: Made sure empty-call-then-add-one-stream test doesn't do simultaneous negotiations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Will now not allow simultaneous negotiations. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "content/browser/web_contents/web_contents_impl.h" 7 #include "content/browser/web_contents/web_contents_impl.h"
8 #include "content/public/common/content_switches.h" 8 #include "content/public/common/content_switches.h"
9 #include "content/public/test/browser_test_utils.h" 9 #include "content/public/test/browser_test_utils.h"
10 #include "content/shell/shell.h" 10 #include "content/shell/shell.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 } 107 }
108 108
109 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CanSetupCallAndSendDtmf) { 109 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CanSetupCallAndSendDtmf) {
110 GURL url(test_server()->GetURL("files/media/peerconnection-call.html")); 110 GURL url(test_server()->GetURL("files/media/peerconnection-call.html"));
111 NavigateToURL(shell(), url); 111 NavigateToURL(shell(), url);
112 112
113 EXPECT_TRUE( 113 EXPECT_TRUE(
114 ExecuteJavascript("callAndSendDtmf('123,abc');")); 114 ExecuteJavascript("callAndSendDtmf('123,abc');"));
115 } 115 }
116 116
117 // TODO(miu): Test is flaky. http://crbug.com/236102
118 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, 117 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest,
119 DISABLED_CanMakeEmptyCallThenAddStreamsAndRenegotiate) { 118 CanMakeEmptyCallThenAddStreamsAndRenegotiate) {
120 GURL url(test_server()->GetURL("files/media/peerconnection-call.html")); 119 GURL url(test_server()->GetURL("files/media/peerconnection-call.html"));
121 NavigateToURL(shell(), url); 120 NavigateToURL(shell(), url);
122 121
123 const char* kJavascript = 122 const char* kJavascript =
124 "makeEmptyCallThenAddOneStreamAndRenegotiate(" 123 "callEmptyThenAddOneStreamAndRenegotiate({video: true, audio: true});";
125 "{video: true, audio: true});";
126 EXPECT_TRUE(ExecuteJavascript(kJavascript)); 124 EXPECT_TRUE(ExecuteJavascript(kJavascript));
127 ExpectTitle("OK"); 125 ExpectTitle("OK");
128 } 126 }
129 127
130 // This test will make a complete PeerConnection-based call but remove the 128 // This test will make a complete PeerConnection-based call but remove the
131 // MSID and bundle attribute from the initial offer to verify that 129 // MSID and bundle attribute from the initial offer to verify that
132 // video is playing for the call even if the initiating client don't support 130 // video is playing for the call even if the initiating client don't support
133 // MSID. http://tools.ietf.org/html/draft-alvestrand-rtcweb-msid-02 131 // MSID. http://tools.ietf.org/html/draft-alvestrand-rtcweb-msid-02
134 #if defined(OS_WIN) && defined(USE_AURA) 132 #if defined(OS_WIN) && defined(USE_AURA)
135 // Disabled for win7_aura, see http://crbug.com/235089. 133 // Disabled for win7_aura, see http://crbug.com/235089.
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CallAndModifyStream) { 214 IN_PROC_BROWSER_TEST_F(WebrtcBrowserTest, MANUAL_CallAndModifyStream) {
217 GURL url(test_server()->GetURL("files/media/peerconnection-call.html")); 215 GURL url(test_server()->GetURL("files/media/peerconnection-call.html"));
218 NavigateToURL(shell(), url); 216 NavigateToURL(shell(), url);
219 217
220 EXPECT_TRUE( 218 EXPECT_TRUE(
221 ExecuteJavascript("callWithNewVideoMediaStreamLaterSwitchToAudio();")); 219 ExecuteJavascript("callWithNewVideoMediaStreamLaterSwitchToAudio();"));
222 ExpectTitle("OK"); 220 ExpectTitle("OK");
223 } 221 }
224 222
225 } // namespace content 223 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/test/data/media/peerconnection-call.html » ('j') | content/test/data/media/peerconnection-call.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698