Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1568763002: [turbofan] Ship TurboFan with new.target references. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship TurboFan with new.target references. This correctly marks functions containing a new.target reference as being disabled with Crankshaft, which would have bailed out anyways. Also note that this will trigger TurboFan for such functions and hence widens the TurboFan intake valve. Committed: https://crrev.com/020b419c7379500cb3447c206d2ba9724fa0149a Cr-Commit-Position: refs/heads/master@{#33146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Jaro, Date constructor is no longer blocking new.target in TurboFan. :-) Please take a ...
4 years, 11 months ago (2016-01-07 06:29:11 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-07 06:35:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568763002/1
4 years, 11 months ago (2016-01-07 06:37:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 06:38:35 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 06:38:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/020b419c7379500cb3447c206d2ba9724fa0149a
Cr-Commit-Position: refs/heads/master@{#33146}

Powered by Google App Engine
This is Rietveld 408576698