Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 1568713002: Add token position to StoreStaticFieldInstr (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc
index bf1af35ea263b56b47e57a1a395fb90eecc85b69..97cf73521e5800a378d3404dcaa8174f180047be 100644
--- a/runtime/vm/flow_graph_builder.cc
+++ b/runtime/vm/flow_graph_builder.cc
@@ -3711,7 +3711,9 @@ void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) {
Definition* EffectGraphVisitor::BuildStoreStaticField(
- StoreStaticFieldNode* node, bool result_is_needed) {
+ StoreStaticFieldNode* node,
+ bool result_is_needed,
+ intptr_t token_pos) {
ValueGraphVisitor for_value(owner());
node->value()->Visit(&for_value);
Append(for_value);
@@ -3722,7 +3724,7 @@ Definition* EffectGraphVisitor::BuildStoreStaticField(
store_value = for_value.value();
}
StoreStaticFieldInstr* store =
- new(Z) StoreStaticFieldInstr(node->field(), store_value);
+ new(Z) StoreStaticFieldInstr(node->field(), store_value, token_pos);
if (result_is_needed) {
Do(store);
@@ -3734,12 +3736,14 @@ Definition* EffectGraphVisitor::BuildStoreStaticField(
void EffectGraphVisitor::VisitStoreStaticFieldNode(StoreStaticFieldNode* node) {
- ReturnDefinition(BuildStoreStaticField(node, kResultNotNeeded));
+ ReturnDefinition(
+ BuildStoreStaticField(node, kResultNotNeeded, node->token_pos()));
}
void ValueGraphVisitor::VisitStoreStaticFieldNode(StoreStaticFieldNode* node) {
- ReturnDefinition(BuildStoreStaticField(node, kResultNeeded));
+ ReturnDefinition(
+ BuildStoreStaticField(node, kResultNeeded, node->token_pos()));
}
« no previous file with comments | « runtime/vm/flow_graph_builder.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698