Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1568703002: Add Bluetooth settings dialog tests (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Bluetooth settings dialog tests BUG=543299 Committed: https://crrev.com/6f483dbce3abab5dbea682bc91f6de8bdd2fd44b Cr-Commit-Position: refs/heads/master@{#368371}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -16 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js View 1 2 4 chunks +51 lines, -5 lines 0 comments Download
M chrome/test/data/webui/settings/fake_bluetooth.js View 3 chunks +16 lines, -8 lines 0 comments Download
M chrome/test/data/webui/settings/fake_bluetooth_private.js View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
stevenjb
4 years, 11 months ago (2016-01-06 22:28:26 UTC) #2
michaelpg
1 character away from LGTM ;-) https://codereview.chromium.org/1568703002/diff/20001/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js File chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js (right): https://codereview.chromium.org/1568703002/diff/20001/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js#newcode184 chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js:184: // Close the ...
4 years, 11 months ago (2016-01-08 03:02:53 UTC) #3
stevenjb
https://codereview.chromium.org/1568703002/diff/20001/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js File chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js (right): https://codereview.chromium.org/1568703002/diff/20001/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js#newcode184 chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js:184: // Close the dialog On 2016/01/08 03:02:53, michaelpg wrote: ...
4 years, 11 months ago (2016-01-08 16:48:01 UTC) #4
stevenjb
4 years, 11 months ago (2016-01-08 16:48:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568703002/40001
4 years, 11 months ago (2016-01-08 16:48:42 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-08 17:59:29 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 18:00:28 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6f483dbce3abab5dbea682bc91f6de8bdd2fd44b
Cr-Commit-Position: refs/heads/master@{#368371}

Powered by Google App Engine
This is Rietveld 408576698