Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1568653002: Add some generic method tests (currently failing) (Closed)

Created:
4 years, 11 months ago by Leaf
Modified:
4 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org, Brian Wilkerson, Paul Berry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some generic method tests (currently failing). This adds tests for some cases where explicit or inferred invocation of generic methods is not working yet, and also for an issue around function typed parameters. The tests currently fail. It also adds some missing calls to super.setUp that were preventing solo_test from working correctly. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/6d4e37cddc54fb949b035d97bd73cfe80639dbb9

Patch Set 1 #

Patch Set 2 : Sort and format #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -0 lines) Patch
M pkg/analyzer/test/generated/resolver_test.dart View 1 2 3 chunks +214 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Leaf
4 years, 11 months ago (2016-01-06 21:34:01 UTC) #3
Jennifer Messerly
LGTM, thank you!
4 years, 11 months ago (2016-01-06 21:37:43 UTC) #4
Jennifer Messerly
Oh BTW, you shouldn't need the dynamic/*=T*/ pattern anymore. I believe that parsing bug was ...
4 years, 11 months ago (2016-01-06 21:38:25 UTC) #5
Leaf
4 years, 11 months ago (2016-01-06 21:43:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6d4e37cddc54fb949b035d97bd73cfe80639dbb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698